-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize browser/ntp_background #26552
base: master
Are you sure you want to change the base?
Conversation
f176182
to
2aea2a2
Compare
sources = [] | ||
deps = [] | ||
|
||
if (enable_custom_background) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bad pattern that has been used a lot unforunately. We should not be creating an empty target when the buildflag is disabled, the target itself should be wrapped in the buildflag
browser/ntp_background/BUILD.gn
Outdated
|
||
if (is_android) { | ||
sources += [ | ||
"android/ntp_background_images_bridge.cc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be better to put these in a separate BUILD.gn in android
directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
2aea2a2
to
54b7e25
Compare
54b7e25
to
eed2e81
Compare
Resolves brave/brave-browser#42299
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: