-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dialog]: Don't fire close event when display: none
#999
Open
fallaciousreasoning
wants to merge
1
commit into
main
Choose a base branch
from
dialog-visibility
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://999.pr.nala.bravesoftware.com/ - ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 119686 bytes
+ ./tokens/css/variables.css: 119686 bytes
Variables Diff: variables-android.diff--- ./tokens/css/variables-android.old.css 2025-02-26 00:56:01.724520355 +0000
+++ ./tokens/css/variables-android.css 2025-02-26 00:55:21.323991180 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue Feb 25 2025 21:26:04 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 00:55:21 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-browser.diff--- ./tokens/css/variables-browser.old.css 2025-02-26 00:56:02.071516184 +0000
+++ ./tokens/css/variables-browser.css 2025-02-26 00:55:21.301991431 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue Feb 25 2025 21:26:04 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 00:55:21 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-ios.diff--- ./tokens/css/variables-ios.old.css 2025-02-26 00:56:02.334513113 +0000
+++ ./tokens/css/variables-ios.css 2025-02-26 00:55:21.345990929 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue Feb 25 2025 21:26:04 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 00:55:21 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-marketing.diff--- ./tokens/css/variables-marketing.old.css 2025-02-26 00:56:02.581510266 +0000
+++ ./tokens/css/variables-marketing.css 2025-02-26 00:55:21.369990654 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue Feb 25 2025 21:26:04 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 00:55:21 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-news.diff--- ./tokens/css/variables-news.old.css 2025-02-26 00:56:02.825507444 +0000
+++ ./tokens/css/variables-news.css 2025-02-26 00:55:21.399990312 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue Feb 25 2025 21:26:04 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 00:55:21 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-newtab.diff--- ./tokens/css/variables-newtab.old.css 2025-02-26 00:56:03.069504583 +0000
+++ ./tokens/css/variables-newtab.css 2025-02-26 00:55:21.410990186 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue Feb 25 2025 21:26:04 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 00:55:21 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-search.diff--- ./tokens/css/variables-search.old.css 2025-02-26 00:56:03.316501685 +0000
+++ ./tokens/css/variables-search.css 2025-02-26 00:55:21.392990392 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue Feb 25 2025 21:26:04 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 00:55:21 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-web3.diff--- ./tokens/css/variables-web3.old.css 2025-02-26 00:56:03.444500183 +0000
+++ ./tokens/css/variables-web3.css 2025-02-26 00:55:21.417990106 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue Feb 25 2025 21:26:04 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 00:55:21 GMT+0000 (Coordinated Universal Time)
*/
@media (prefers-color-scheme: light) {
Variables Diff: variables.diff--- ./tokens/css/variables.old.css 2025-02-26 00:56:03.821495763 +0000
+++ ./tokens/css/variables.css 2025-02-26 00:55:21.151993145 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Tue Feb 25 2025 21:26:04 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Feb 26 2025 00:55:21 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a situation in
brave-core
where I want to conditionally render some content in a dialog. I need to control this solely via CSS.It works pretty well, except that the close event is fired on the dialog, even when it is
display: none