Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an up-to-date feature-rich example serverless.yml config #103

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aran112000
Copy link

Example serverless.yml config for the updated Laravel Bridge for Bref 2.

Default config for Octane support (simply swap the web functions over to use)

This uses Lift constructs to:

  • Create a default SQS queue and link to Laravel queues seamlessly
  • Create a Cloudfront website front-end and S3 bucket for serving static assets from within your domain

Copy link
Member

@tillkruss tillkruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stub is being used as the default. Please add it yours to the examples directory.

@georgeboot
Copy link
Contributor

Seems to conflict with #100

Perhaps it's best to provide a simple default (like in #100) and document (or even, provide examples) of more advanced setups like the one in this PR?

Thoughts?

@aran112000
Copy link
Author

No worries, I'll review this weekend and move it over to the examples

@tillkruss
Copy link
Member

Perhaps it's best to provide a simple default (like in #100) and document (or even, provide examples) of more advanced setups like the one in this PR?

I was thinking we have a dozen example files (or folders) in examples.

Copy link
Member

@mnapoli mnapoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on moving this to an example. In the meantime, I reviewed the current diff in case that helps! (added comments inline)

stubs/serverless.yml Outdated Show resolved Hide resolved
stubs/serverless.yml Outdated Show resolved Hide resolved
stubs/serverless.yml Outdated Show resolved Hide resolved
stubs/serverless.yml Outdated Show resolved Hide resolved
stubs/serverless.yml Outdated Show resolved Hide resolved
stubs/serverless.yml Outdated Show resolved Hide resolved
stubs/serverless.yml Outdated Show resolved Hide resolved
stubs/serverless.yml Outdated Show resolved Hide resolved
stubs/serverless.yml Outdated Show resolved Hide resolved
stubs/serverless.yml Outdated Show resolved Hide resolved
@aran112000 aran112000 reopened this Mar 20, 2023
@tillkruss
Copy link
Member

I'm ooo this week. @georgeboot @mnapoli

examples/ququed/serverless.yml Outdated Show resolved Hide resolved
examples/ququed/serverless.yml Outdated Show resolved Hide resolved
examples/ququed/serverless.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants