Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextclade 1.2.3 (new formula) #1394

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

corneliusroemer
Copy link

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source FORMULA, where FORMULA is the name of the formula you're submitting?
  • Does your build pass brew audit --strict FORMULA (after doing brew install FORMULA)?

This is my first foray into packaging with brew. Feedback welcome!

@sjackman
Copy link
Member

The CI error /__w/homebrew-bio/homebrew-bio/.git: Permission denied is unrelated to your PR. I'll take a look at it just as soon as I can find some time. Thank you for your patience.

@corneliusroemer
Copy link
Author

Thanks @sjackman! I figured out myself that this probably wasn't my PR and opened this issue for the root error: #1395

@eseiler
Copy link
Contributor

eseiler commented Aug 31, 2021

@corneliusroemer Can you rebase this on the current develop?

@corneliusroemer
Copy link
Author

@eseiler Done! Someone needs to approve running workflows though, unfortunately. Maybe @sjackman @YoshitakaMo @jonchang @zbeekman? Not sure who has the rights.

@jonchang
Copy link
Member

I've started CI checks on this. Note that you could probably just submit this to homebrew/core instead, as long as you provide a better test in the test do block.

@jonchang
Copy link
Member

Try fails_with gcc: "5" for Linux.

@corneliusroemer
Copy link
Author

When I try to build it locally in an Ubuntu docker image using brew install --build-from-source --verbose --debug nextclade.rb I get the following error:

/home/linuxbrew/.linuxbrew/Cellar/gcc/11.2.0/lib/gcc/11/gcc/x86_64-pc-linux-gnu/11.2.0/include/waitpkgintrin.h:53:1: error: inlining failed in call to 'always_inline' 'unsigned char _tpause(unsigned int, long long unsigned int)': target specific option mismatch
   53 | _tpause (unsigned int __A, unsigned long long __B)
      | ^~~~~~~

Not sure what's the problem since I can build it without brew just using make prod and there are no errors.

Any ideas?

@jonchang
Copy link
Member

jonchang commented Sep 1, 2021

Not sure what's the problem since I can build it without brew just using make prod and there are no errors.

You're likely using a different compiler from your host environment than brew's compiler.

oneapi-src/oneTBB#370

It is likely an issue in this dependency when compiling with gcc 11.

@corneliusroemer
Copy link
Author

Thanks! I didn't find that bug. So I would have to tell brew that all but gcc 9 works - or at least that gcc@11 doesn't.

@jonchang
Copy link
Member

jonchang commented Sep 1, 2021

Yes, you'll need to add a fails_with for gcc 11.

I also want to reiterate that you should submit this to https://github.com/homebrew/homebrew-core, since the CI resources there are better (including for ARM macOS) and that repository gets more visibility than this one.

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants