Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libstatgen 1.0.15 #1857

Merged
merged 1 commit into from
Oct 3, 2024
Merged

libstatgen 1.0.15 #1857

merged 1 commit into from
Oct 3, 2024

Conversation

alexreg
Copy link
Contributor

@alexreg alexreg commented Sep 2, 2024

This will be needed for bamUtil, for which I will submit a new formula PR shortly.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source --verbose --keep-tmp ./Formula/<FORMULA>.rb, where FORMULA is the name of the formula you're submitting?
  • Does your formula have no offenses with brew style /path/to/formula.rb?
  • Does your formula pass brew audit --formula brewsci/bio/<FORMULA> --online --git --skip-style?
  • Does your formula pass brew linkage --cached --test --strict brewsci/bio/<FORMULA> after manual installation?

@YoshitakaMo
Copy link
Contributor

Can the URL be changed to pass the test?

@alexreg
Copy link
Contributor Author

alexreg commented Sep 4, 2024

@YoshitakaMo That's odd it's saying it's not reachable, as I can reach it with no problems here. Maybe a ephemeral error, and CI simply needs to be rerun?

@YoshitakaMo
Copy link
Contributor

@alexreg I re-runed the CI several times but finally failed. Curiously, I can reach the website https://genome.sph.umich.edu/wiki/C%2B%2B_Library:_libStatGen from my mac, but not from my Linux with the command curl "https://genome.sph.umich.edu/wiki/C%2B%2B_Library:_libStatGen". Probably this is the cause.

I recommend changing that URL to the GitHub one, https://github.com/statgen/libStatGen.

@alexreg
Copy link
Contributor Author

alexreg commented Oct 2, 2024

@YoshitakaMo Yeah, that sounds fair. It doesn't like the colon in the URL, most likely. I've done what you suggested and pushed now.

@YoshitakaMo
Copy link
Contributor

Perhaps the -lstatgen flag should be -lStatGen because the flag is case-sensitive on Linux (but not on macOS).

@YoshitakaMo YoshitakaMo merged commit 5047379 into brewsci:develop Oct 3, 2024
4 checks passed
@YoshitakaMo
Copy link
Contributor

Merged! Thank you, @alexreg !

@alexreg alexreg deleted the libstatgen branch October 3, 2024 18:26
@alexreg alexreg restored the libstatgen branch October 3, 2024 18:26
@alexreg alexreg deleted the libstatgen branch October 3, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants