Add support for all currencies #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Adds support for currencies other than USD and EUR by using USD as an intermediary currency.
For example, if CAD is selected, the exchange rate will be calculated by multiplying the BTC->USD rate by the USD->CAD rate.
I've tested the result against my own account (currently have a balance of ~ CAD$70, and I can confirm that the amount reported in Home Assistant matches what's reported in the NiceHash UI, to the cent. So it's likely that NiceHash is using the exact same formula.
One downside of my implementation is that the USD currency icon will be used for all non-EUR currencies.