Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing _checkPgPass on _handleAuthSASLContinue #3252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cesco69
Copy link

@cesco69 cesco69 commented Jun 10, 2024

No description provided.

@charmander
Copy link
Collaborator

Why does this one need _checkPgPass on top of _handleAuthSASL’s?

@cesco69
Copy link
Author

cesco69 commented Jun 11, 2024

Why does this one need _checkPgPass on top of _handleAuthSASL’s?

this.password can be a function and _checkPgPass handle this case, if this.password is a function, call it and set this.password as string

@charmander
Copy link
Collaborator

Does _handleAuthSASL not already take care of that? Can you give an example of a use of the library that behaves differently before and after this change?

@brianc
Copy link
Owner

brianc commented Jun 18, 2024

yeah I need tests (preferably one that failed before this code was added) or this can't be merged. As an aside, I am thinking of removing built in pg-pass support & rather making that something the user does their own self before calling the client rather than reading a file from disk on every client connection. That would obvs be a breaking change so not until v 9.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants