-
Notifications
You must be signed in to change notification settings - Fork 32
LPD-73835 Make import and override structure asynchronous #169136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-73835 Make import and override structure asynchronous #169136
Conversation
…structure to get the values, so add a thread local for it
…, otherwise we will end with incorrect values
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesRan com.liferay.source.formatter at released version 1.0.1556. Click here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-73835-3 1 Successful Jobs:For more details click here. |
✔️ ci:test:stable - 12 out of 12 jobs passed❌ ci:test:relevant - 13 out of 18 jobs passed in 1 hour 51 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 61d5ca82617c02030af280c2b97e0d45a8c99e45 ci:test:stable - 12 out of 12 jobs PASSED12 Successful Jobs:ci:test:relevant - 13 out of 18 jobs PASSED5 Failed Jobs:
13 Successful Jobs:For more details click here.Failures unique to this pull:For upstream results, click here. |
|
1.) One is plural JournalArticles, the other is singular JOURNAL_ARTICLE One is JOURNAL_ARTICLE_DDM_STRUCTURE the other is DDMStructureJournalArticles Please fix inconsistencies and resend. 2.) g grep _update **DestinationNames.java Shows the naming of the path is still inconsistent Use |
Forwarded from: liferay-content-management#7624 (Took 1
ci:forwardattempt in 41 seconds)Console
@jkappler
@liferay-content-management
Original pull request comment:
previous PR : liferay-content-management#7581
Updated to always be async based on #168881 (comment)
previous PR : #169107
Updated destination path based on #169107 (comment)
What is this trying to solve?
https://liferay.atlassian.net/browse/LPD-73835
During migrations and upgrades, it is sometimes necessary to import structures that will end up creating long running processes. This usually causes HTTP timeouts, as the current implementation runs synchronously in the tomcat thread.
How am I fixing it?
By making the update call asynchronous through message bus
By adding a configuration option (disabled by default) to run "import and override" jobs asynchronously.Why doesn't this include any test?
This changes timing, not behaviour, which is very difficult to test without flakyness.