Skip to content

Conversation

@liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-content-management#7624 (Took 1 ci:forward attempt in 41 seconds)
Console

@jkappler
@liferay-content-management

Original pull request comment:
previous PR : liferay-content-management#7581
Updated to always be async based on #168881 (comment)

previous PR : #169107
Updated destination path based on #169107 (comment)

What is this trying to solve?

https://liferay.atlassian.net/browse/LPD-73835

During migrations and upgrades, it is sometimes necessary to import structures that will end up creating long running processes. This usually causes HTTP timeouts, as the current implementation runs synchronously in the tomcat thread.

How am I fixing it?

By making the update call asynchronous through message bus
By adding a configuration option (disabled by default) to run "import and override" jobs asynchronously.

Why doesn't this include any test?

This changes timing, not behaviour, which is very difficult to test without flakyness.

@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@liferay-continuous-integration
Copy link
Collaborator Author

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Ran com.liferay.source.formatter at released version 1.0.1556.
*The latest version has not been released.

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 93b4619e92f3a8b21cb7a8d59057041e91ed4b13

Sender Branch:

Branch Name: LPD-73835-3
Branch GIT ID: 0d7a60d206f8e2fd8a61ef33f7f5aee8f7b1753e

1 out of 1 jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator Author

✔️ ci:test:stable - 12 out of 12 jobs passed

❌ ci:test:relevant - 13 out of 18 jobs passed in 1 hour 51 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 93b4619e92f3a8b21cb7a8d59057041e91ed4b13

Upstream Comparison:

Branch GIT ID: 61d5ca82617c02030af280c2b97e0d45a8c99e45
Jenkins Build URL: EE Development Acceptance (master) - 345 - 2025-12-30[08:39:21]

ci:test:stable - 12 out of 12 jobs PASSED
12 Successful Jobs:
    ci:test:relevant - 13 out of 18 jobs PASSED

    5 Failed Jobs:

    13 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      For upstream results, click here.

      @brianchandotcom
      Copy link
      Owner

      @adolfopa @balazssk @jkappler

      1.)

      @Component(
      	property = "destination.name=" + JournalDestinationNames.JOURNAL_ARTICLE_DDM_STRUCTURE_UPDATE,
      	service = MessageListener.class
      )
      public class DDMStructureJournalArticlesUpdateMessageListener
      	extends BaseMessageListener {
      

      One is plural JournalArticles, the other is singular JOURNAL_ARTICLE

      One is JOURNAL_ARTICLE_DDM_STRUCTURE the other is DDMStructureJournalArticles

      Please fix inconsistencies and resend.

      2.) g grep _update **DestinationNames.java

      Shows the naming of the path is still inconsistent

      Use g ls-files **DestinationNames.java and look at every single existing path and use the existing naming patterns.

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Labels

      None yet

      Projects

      None yet

      Development

      Successfully merging this pull request may close these issues.

      5 participants