Skip to content

Conversation

@liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-content-management#7588 (Took 4 ci:forward attempts in 8 days 2 hours 34 minutes)
Console

@ak-ragnor
@liferay-content-management

Original pull request comment:

What is this trying to solve?

https://liferay.atlassian.net/browse/LPD-74358

putSiteStructuredContentByExternalReferenceCode does not work correctly for the following field types:

  • Select from List
  • Multiple Selection
  • Single Selection
  • Link to Page
  • Image
  • Geolocation
  • Web Content

How am I fixing it?

By using DDMValueUtil to properly extract and handle the field values.

How can you verify that it works?

An existing test already covers this scenario: testPutStructuredContent.

@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@liferay-continuous-integration
Copy link
Collaborator Author

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Ran com.liferay.source.formatter at released version 1.0.1556.
*The latest version has not been released.

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c13ed96f74005bfbf639995c826bb08ede1df676

Sender Branch:

Branch Name: LPD-74358
Branch GIT ID: 4d3754c7162fb773e597f3ea7ad28ded43aca57f

1 out of 1 jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator Author

✔️ ci:test:stable - 12 out of 12 jobs passed

❌ ci:test:relevant - 16 out of 20 jobs passed in 1 hour 39 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c13ed96f74005bfbf639995c826bb08ede1df676

Upstream Comparison:

Branch GIT ID: 3caaae541983f488a2604020ca9a51b57f821b2a
Jenkins Build URL: EE Development Acceptance (master) - 352 - 2026-01-05[08:43:05]

ci:test:stable - 12 out of 12 jobs PASSED
12 Successful Jobs:
    ci:test:relevant - 16 out of 20 jobs PASSED

    4 Failed Jobs:

    16 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      For upstream results, click here.

      @brianchandotcom
      Copy link
      Owner

      @ak-ragnor you use the word "complete" and "complex". What's the difference? Please resend on top of ak-ragnor#11

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Labels

      None yet

      Projects

      None yet

      Development

      Successfully merging this pull request may close these issues.

      3 participants