fix(#2809): make Algorithm getters const#2817
Open
jalil-salame wants to merge 1 commit intobriansmith:mainfrom
Open
fix(#2809): make Algorithm getters const#2817jalil-salame wants to merge 1 commit intobriansmith:mainfrom
jalil-salame wants to merge 1 commit intobriansmith:mainfrom
Conversation
briansmith
requested changes
Apr 30, 2026
Owner
briansmith
left a comment
briansmith
left a comment
There was a problem hiding this comment.
Thank you. Could you please update the commit message, e.g. "aead/quic: Make key/nonce/tag length accessors const."? We generally want the commit messages to be independent of any GitHub-isms.
This allows using the `key_len` in constants for type safety, e.g. ```rust type CHACHA_KEY = [u8; ring::aead::CHACHA20_POLY1305.key_len()]; static DEFAULT_KEY: CHACHA_KEY = [0; ring::aead::CHACHA20_POLY1305.key_len()]; ``` Signed-off-by: Jalil David Salamé Messina <jalil.salame@gmail.com>
jalil-salame
force-pushed
the
jalil/const-getters
branch
from
54eab20 to
87a34b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using the
key_lenin constants for type safety, e.g.Closes #2809