feat: upgrade to Excalidraw 0.18.0 with legacy file compatibility#492
Open
Technophobe01 wants to merge 1 commit intobric3:mainfrom
Open
feat: upgrade to Excalidraw 0.18.0 with legacy file compatibility#492Technophobe01 wants to merge 1 commit intobric3:mainfrom
Technophobe01 wants to merge 1 commit intobric3:mainfrom
Conversation
5 tasks
Owner
|
Hello, sorry for the delay, I was off, then had to "unpile" stuff at work. I haven't looked at the code yet. But there are still a few issues, and I don't think Claude solved them
Please avoid closing and re-oping a new PR, this makes things difficult to review. |
Contributor
Author
|
Let me take a look at the code and check against your comments. As an aside, I may have do / undo working still noodling on two edge cases. |
Closes bric3#423 Build System Migration: - Migrated from react-scripts (Webpack) to Vite for faster builds - Updated TypeScript configuration for Vite compatibility - Set "type": "module" in package.json for ESM support Excalidraw 0.18.0 Compatibility: - Updated @excalidraw/excalidraw to 0.18.0 - Added required CSS import for new Excalidraw styles - Self-hosted fonts with EXCALIDRAW_ASSET_PATH (no CDN dependency) - Fixed IDE theme integration with Excalidraw wrapper Legacy File Support: - Added preprocessing for older Excalidraw file formats (boundElements, frameId, lineHeight fixes) - Fixed embedded SVG/PNG scene loading and encoded payload handling - Fixed font loading for deprecated fonts (Virgil, Helvetica, Cascadia) Signed-off-by: Technophobe01 <pkjarvis01@gmail.com>
db368cf to
d08b56e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #423
Upgrades the embedded Excalidraw library from 0.17.x to 0.18.0 with full backward compatibility.
Changes
Build System Migration
"type": "module"in package.json for ESM supportExcalidraw 0.18.0 Compatibility
@excalidraw/excalidrawto 0.18.0EXCALIDRAW_ASSET_PATH(no CDN dependency)Legacy File Support
Test Plan