Fix gCNV retry seed being deterministic and potentially negative#9346
Open
dami-gupta-git wants to merge 1 commit intobroadinstitute:masterfrom
Open
Fix gCNV retry seed being deterministic and potentially negative#9346dami-gupta-git wants to merge 1 commit intobroadinstitute:masterfrom
dami-gupta-git wants to merge 1 commit intobroadinstitute:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inference diverges and we retry, we were initializing Random with a constant seed via
new Random(STARTING_SEED).nextInt(). This had two problems: the retry seed was always the same value, and nextInt() can return negative integers, which are rejected by numpy's RandomState in the Python script, This caused the retry to immediately crash rather than attempt convergence.Fixed by using
new Random().nextInt(Integer.MAX_VALUE)so the retry gets a genuinely different, non-negative seed each time.Added a unit test to cover the new generateRetrySeed method.