Skip to content

index columns starting by 1 in Locator #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xworld21 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

index columns starting by 1 in Locator #2671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/LaTeXML/Common/Locator.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ case of an anonymous string. C<$fromLine> and C<$fromCol> should be integers
containing the line and column numbers of the start of the range in the source
file, or undef if unknown. C<$toLine> and C<$toCol> should be the integers
containing the line and column numbers of the end of the range, or undef
if a point is being referred to.
if a point is being referred to. Lines and columns should be 1-indexed.

=item C<< $locator = LaTeXML::Common::Locator->newRange($from, $to); >>

Expand Down
2 changes: 1 addition & 1 deletion lib/LaTeXML/Core/Mouth.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ sub getLocator {
else {
$fromLine = $toLine;
$fromCol = $toCol; }
return LaTeXML::Common::Locator->new($$self{source}, $fromLine, $fromCol, $toLine, $toCol); }
return LaTeXML::Common::Locator->new($$self{source}, $fromLine, $fromCol + 1, $toLine, $toCol + 1); }

sub getSource {
my ($self) = @_;
Expand Down
2 changes: 1 addition & 1 deletion lib/LaTeXML/Package.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2738,7 +2738,7 @@ sub LoadFormat {
&& FindFile($format . '_dump', type => 'pool', notex => 1,
installation_subdir => 'Engine')) { # dump of $format?
LoadPool($format . '_bootstrap', noerror => 1);
local $LaTeXML::LOCATOR = LaTeXML::Common::Locator->new($format, 0, 0, 0, 0);
local $LaTeXML::LOCATOR = LaTeXML::Common::Locator->new($format, 1, 1, 1, 1);
$success = LoadPool($format . '_dump');
LoadPool($format . '_constructs', noerror => 1); }
elsif (FindFile($format . '_base', type => 'pool', notex => 1,
Expand Down