Robust on raw perl value instead of register value #2693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was encountered in
arXiv:2308.06254v1, where a use of\famwas returning a perl0scalar value fromreadRegisterValue.I think we should harden
readRegisterValueto always return an object, catching these cases and defaulting them to what the coercing would do, orNumberif nothing else is known.With the change in the PR the article converts without a Fatal, instead emitting a warning:
That can also be made into an error if preferred. Encountered in an old issue when processed with the latest latexml worker, at arXiv/html_feedback#22
Diff without whitespace lints at https://github.com/brucemiller/LaTeXML/pull/2693/files?w=1