guard pgfNumber against double negation #2711
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2696
This may be a bit "too direct" in addressing the parameter symptom, as I have not dived to the full depths of how the
--0.5was generated. What was clear from testing is that this is not coming from any of our perl binding code, neither is it directly interceptable in the usualpgfmathparseroutine.On the other hand, guarding a number parameter type for double negation seems both easy and uncontroversial. So possibly a reasonable patch?
Most importantly, the resulting SVG is quite impressively matching the PDF of the example.