Landing page overhaul, improve accessibility, and refactor codebase #245
Conversation
|
Again, thx for that ! There is only a point that i would like to discuss : the hero screencast is not a good idea imho :
Without this, i'm ready to merge this one, and push a release to promote #244 PS : i've seen that e have a problem on demo page with small screen under 460px width, the main title s cropped and generate a horizontal scroll, this should be fixed by simple change the title to "Leaflet Control FullScreen". Any thought bout this ? |
The toggleFullScreen() and toggleFullscreen() methods now return Promise<void> instead of void to match the async implementation introduced in the recent refactoring.
The fullscreenchange event only fires on document, not on individual elements. Removed unnecessary event listeners on the container element in both _createButton and onRemove methods.
Use flexbox layout to ensure the footer always stays at the bottom of the viewport on large monitors. The main content area now expands to fill available space, pushing the footer down.
Improves screen reader support by adding aria-pressed attribute that indicates whether fullscreen mode is currently active or not. The attribute toggles between "true" and "false" in _toggleState().
- Remove CARTO dark tiles due to unclear licensing - Use CSS filter (invert + hue-rotate) on standard OSM tiles - Improve performance by loading tiles only once - Simplify dark mode implementation in demo - Fix attribution background color in dark mode
KristjanESPERANTO
force-pushed
the
refactor
branch
from
28a9878 to
62eaaec
Compare
Yes, I see that the screencast was too much of a plaything. I have removed it.
Done in the landing page. Should we do it also in the README for consitancy? |
Why not :) |
KristjanESPERANTO
force-pushed
the
refactor
branch
from
62eaaec to
0ba859e
Compare
|
Okay, done 🙂 Everywhere I removed |
2 participants
This PR includes several improvements to code quality, accessibility, and documentation:
Landing Page Enhancements
Result: https://kristjanesperanto.github.io/leaflet.fullscreen/
Current version for comparison: https://brunob.github.io/leaflet.fullscreen/
Accessibility
aria-pressedattribute to fullscreen button to indicate active state for screen readersDemo Improvements
invert+hue-rotate) on standard OSM tilesCode Quality
DomUtilwith native DOM methods for element creationfullscreenchangelisteners (event only fires on document)toggleFullScreen()method (discussed here: refactor(core): modernizetoggleFullScreenand synchronize state updates #244 (comment))Dependencies