Armor Loading - #17
Merged
Merged
Conversation
I forgot to proofread the copy pasted code from elsewhere in the file, and some issues came along. It fixes them, and adds some extra scaling fixes.
Collaborator
Contributor
Author
|
Absolutely! Will have to be tomorrow though, I'll be having an exam in the morning |
As well as some weird indent fixes
Contributor
Author
|
I deliberately kept 2 lines in tests.js unformatted because they looked kinda out of place, is that why it's failing? |
Collaborator
|
I think editorconfig was forcing tabs back, push a commit to master so pull that and try formatting again. |
Contributor
Author
|
I tried format:check while keeping those 2 lines and it failed so this time it's fully formatted and should pass |
Collaborator
|
@yushijinhun i don't have publish rights on npm, could you grant me access? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the utils part of the armor rendering PR over at skinview3d.
It contains a function that will basically convert 2 armor layers into a modern skin texture on a canvas.