Support Animated Capes #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hacksore
requested changes
Jan 10, 2023
|
Before merging this, skinview-utils needs to be merged and published so we can update the dependency in this package. |
|
I've also added an example |
Hacksore
requested changes
Jan 11, 2023
|
I have added a fix to stop legacy cape (22x17) being detected as a sprite |
Hacksore
approved these changes
Jan 12, 2023
|
Any update on this? |
yushijinhun
reviewed
Feb 10, 2023
| this.lastFrameTime = currentTime | ||
|
|
||
| if(this.capeSource != null && this.totalFrames > 1) { | ||
| this.loadCape(this.capeSource, this.capeOptions) |
There was a problem hiding this comment.
Calling loadCape() on each frame update would have a huge performance impact. I think it's better to load each frame into a individual canvas and just switch the canvas periodically.
Closed
|
@james090500 has implemented this in this repo ❤️. Going to close this for now as it's a bit hard to get merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports animated capes using a sprite. Example here
Will probably need a manual merge and also needs this to be merged before hand
bs-community/skinview-utils#15