[pull] main from quarkusio:main#236
Merged
Merged
Conversation
Added ConstructorForProjection annotation to indicate the constructor to be used explicitly in projections
In BytecodeTransformerBuildItem, we can define a set of classes which will be used to determine if a class is affected by a transformation by by checking the constant pool. This is most notably (and I think exclusively) used as an optimization for the Panache transformation of public fields -> accessors. When you have an application with a lot of entities, all the BytecodeTransformerBuildItem targeting the classes using these entities are carrying the Set of all the entities. And we used copy the Set over and over for each class affected by the transformation, which was generating a lot of useless allocations. Obviously, this optimization only works if we don't use the constant pool scanning optimization for other transformations. And that why, I ended up adding another optimization: we now only pass to the transformer the entities we have detected as being used in this class instead of the whole list of entities. While doing that should make the first optimization a lot less useful, I think it's still good to keep it around.
We used to apply all transformers if at least one of them was not requiring any constant pool check, including the ones for which we had a constant pool check, which was a bad idea: we now filter the transformers properly and we apply the ones that should be applied. Nice bonus: we don't need to prepare some sort of aggregated config before applying the transformers as we don't need one. All in all, it's faster and should be more correct.
Bumps `narayana-lra.version` from 1.0.1.Final to 1.0.2.Final. Updates `org.jboss.narayana.lra:lra-coordinator-jar` from 1.0.1.Final to 1.0.2.Final Updates `org.jboss.narayana.lra:narayana-lra` from 1.0.1.Final to 1.0.2.Final Updates `org.jboss.narayana.lra:lra-service-base` from 1.0.1.Final to 1.0.2.Final - [Release notes](https://github.com/jbosstm/lra/releases) - [Commits](jbosstm/lra@1.0.1.Final...1.0.2.Final) Updates `org.jboss.narayana.lra:lra-proxy-api` from 1.0.1.Final to 1.0.2.Final Updates `org.jboss.narayana.lra:lra-client` from 1.0.1.Final to 1.0.2.Final - [Release notes](https://github.com/jbosstm/lra/releases) - [Commits](jbosstm/lra@1.0.1.Final...1.0.2.Final) --- updated-dependencies: - dependency-name: org.jboss.narayana.lra:lra-coordinator-jar dependency-version: 1.0.2.Final dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jboss.narayana.lra:narayana-lra dependency-version: 1.0.2.Final dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jboss.narayana.lra:lra-service-base dependency-version: 1.0.2.Final dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jboss.narayana.lra:lra-proxy-api dependency-version: 1.0.2.Final dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jboss.narayana.lra:lra-client dependency-version: 1.0.2.Final dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Hibernate ORM - Assorted improvements to proxy generation
Improve panache projection by supporting multiple constructors
…na-lra.version-1.0.2.Final Bump narayana-lra.version from 1.0.1.Final to 1.0.2.Final
…ation Bytecode transformers - Optimize constant pool scanning optimization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )