[pull] main from quarkusio:main#780
Merged
pull[bot] merged 5 commits intobschuhmann:mainfrom Mar 25, 2026
Merged
Conversation
…ent" This reverts commit 0997645.
We went back and forth on this and it has caused all sorts of issues, the latest having been fixed by: #53187 that I just reverted. I think we need to refactor this and have a very clear and consistent semantic, which should now be the case. The reason why an unclear semantic was detrimental is that ZipFileSystem and Commons Compress have different behavior: - ZipFileSystem only allows one entry per name and will fail if another is added - Commons Compress will happily add several entries with the same name to the Zip file (which is a behavior that is allowed by the format) When I switched from ZipFileSystem to Commons Compress, I didn't see this difference in behavior. Having a clear semantic should avoid all issues. In passing, make ZipFileSystemArchiveCreator consistent with ParallelCommonsCompressArchiveCreator, as it derived a bit. It's not used anymore but who knows...
…n-test Use new QuarkusExtensionTest everywhere
Refactor jar building to a first-write-wins approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )