[pull] main from quarkusio:main#818
Merged
pull[bot] merged 7 commits intobschuhmann:mainfrom Apr 9, 2026
Merged
Conversation
I noticed this was missing while thinking about https://groups.google.com/g/quarkus-dev/c/dddcxKaS5rY/m/_JVSXtitAAAJ?utm_medium=email&utm_source=footer If a Uni gets subscribed to twice, I think we want the Vert.x context to be checked each time, because it might be different.
Validates that when a @transactional method is retried using Mutiny's retry operator: - Failed attempts have their DB changes rolled back - The method is re-executed - Successful attempts have their DB changes committed Without the previous commit, the test fails with: ``` io.quarkus.hibernate.reactive.transaction.HibernateReactiveTransactionalRetryTest.testTransactionalRetry(UniAsserter) -- Time elapsed: 0.327 s <<< ERROR! io.smallrye.mutiny.CompositeException: Multiple exceptions caught: [Exception 0] io.smallrye.mutiny.CompositeException: Multiple exceptions caught: [Exception 0] java.lang.IllegalStateException: Session/EntityManager is closed [Exception 1] java.lang.NullPointerException: Cannot invoke "io.vertx.sqlclient.Transaction.rollback()" because "transaction" is null [Exception 1] io.vertx.core.impl.NoStackTraceThrowable: Connection released twice at io.smallrye.mutiny.operators.uni.UniOnTerminationCall$UniOnTerminationCallProcessor.lambda$onFailure$4(UniOnTerminationCall.java:83) at io.smallrye.context.impl.wrappers.SlowContextualConsumer.accept(SlowContextualConsumer.java:21) at io.smallrye.mutiny.helpers.UniCallbackSubscriber.onFailure(UniCallbackSubscriber.java:62) at io.smallrye.mutiny.operators.uni.builders.DefaultUniEmitter.fail(DefaultUniEmitter.java:53) at io.vertx.core.impl.future.FutureImpl$3.onFailure(FutureImpl.java:151) at io.vertx.core.impl.future.FutureBase.emitFailure(FutureBase.java:81) at io.vertx.core.impl.future.FutureImpl.addListener(FutureImpl.java:226) at io.vertx.core.impl.future.FutureImpl.onComplete(FutureImpl.java:132) at io.quarkus.reactive.transaction.TransactionalInterceptorBase.lambda$toUni$0(TransactionalInterceptorBase.java:163) at io.smallrye.context.impl.wrappers.SlowContextualConsumer.accept(SlowContextualConsumer.java:21) at io.smallrye.mutiny.operators.uni.builders.UniCreateWithEmitter.subscribe(UniCreateWithEmitter.java:22) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.groups.UniSubscribe.withSubscriber(UniSubscribe.java:51) at io.smallrye.mutiny.groups.UniSubscribe.with(UniSubscribe.java:110) at io.smallrye.mutiny.operators.uni.UniOnTerminationCall$UniOnTerminationCallProcessor.onFailure(UniOnTerminationCall.java:80) at io.smallrye.mutiny.operators.uni.UniOnTerminationCall$UniOnTerminationCallProcessor.lambda$onFailure$3(UniOnTerminationCall.java:82) at io.smallrye.context.impl.wrappers.SlowContextualConsumer.accept(SlowContextualConsumer.java:21) at io.smallrye.mutiny.helpers.UniCallbackSubscriber.onItem(UniCallbackSubscriber.java:73) at io.smallrye.mutiny.operators.uni.UniOnTermination$UniOnTerminationProcessor.onItem(UniOnTermination.java:39) at io.smallrye.mutiny.operators.uni.builders.UniCreateFromKnownItem$KnownItemSubscription.forward(UniCreateFromKnownItem.java:42) at io.smallrye.mutiny.operators.uni.builders.UniCreateFromKnownItem.subscribe(UniCreateFromKnownItem.java:23) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.operators.uni.UniOnTermination.subscribe(UniOnTermination.java:21) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.groups.UniSubscribe.withSubscriber(UniSubscribe.java:51) at io.smallrye.mutiny.groups.UniSubscribe.with(UniSubscribe.java:110) at io.smallrye.mutiny.operators.uni.UniOnTerminationCall$UniOnTerminationCallProcessor.onFailure(UniOnTerminationCall.java:80) at io.smallrye.mutiny.operators.uni.UniOperatorProcessor.onFailure(UniOperatorProcessor.java:55) at io.smallrye.mutiny.operators.uni.UniOnCancellationCall$UniOnCancellationCallProcessor.onFailure(UniOnCancellationCall.java:59) at io.smallrye.mutiny.operators.uni.UniOnFailureFlatMap$UniOnFailureFlatMapProcessor.performInnerSubscription(UniOnFailureFlatMap.java:97) at io.smallrye.mutiny.operators.uni.UniOnFailureFlatMap$UniOnFailureFlatMapProcessor.dispatch(UniOnFailureFlatMap.java:86) at io.smallrye.mutiny.operators.uni.UniOnFailureFlatMap$UniOnFailureFlatMapProcessor.onFailure(UniOnFailureFlatMap.java:63) at io.smallrye.mutiny.operators.uni.UniOnItemConsume$UniOnItemComsumeProcessor.onFailure(UniOnItemConsume.java:69) at io.smallrye.mutiny.operators.uni.UniOperatorProcessor.onFailure(UniOperatorProcessor.java:55) at io.smallrye.mutiny.operators.uni.UniOperatorProcessor.onFailure(UniOperatorProcessor.java:55) at io.smallrye.mutiny.helpers.EmptyUniSubscription.propagateFailureEvent(EmptyUniSubscription.java:40) at io.smallrye.mutiny.operators.uni.builders.UniCreateFromCompletionStage.subscribe(UniCreateFromCompletionStage.java:26) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.operators.uni.UniRunSubscribeOn.lambda$subscribe$0(UniRunSubscribeOn.java:27) at org.hibernate.reactive.context.impl.VertxContext.execute(VertxContext.java:90) at io.smallrye.mutiny.operators.uni.UniRunSubscribeOn.subscribe(UniRunSubscribeOn.java:25) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.operators.uni.UniOnItemTransform.subscribe(UniOnItemTransform.java:22) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.operators.uni.UniOnItemConsume.subscribe(UniOnItemConsume.java:34) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.operators.uni.UniOnFailureFlatMap.subscribe(UniOnFailureFlatMap.java:34) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.operators.uni.UniOnCancellationCall.subscribe(UniOnCancellationCall.java:27) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.operators.uni.UniOnItemTransformToUni.subscribe(UniOnItemTransformToUni.java:25) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.groups.UniSubscribe.withSubscriber(UniSubscribe.java:51) at io.smallrye.mutiny.operators.uni.UniOnTerminationCall.subscribe(UniOnTerminationCall.java:28) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.groups.UniSubscribe.withSubscriber(UniSubscribe.java:51) at io.smallrye.mutiny.operators.uni.UniOnTerminationCall.subscribe(UniOnTerminationCall.java:28) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.operators.uni.UniRetryAtMost$UniRetryAtMostProcessor.onFailure(UniRetryAtMost.java:74) at io.smallrye.mutiny.operators.uni.UniOnTerminationCall$UniOnTerminationCallProcessor.lambda$onFailure$3(UniOnTerminationCall.java:82) at io.smallrye.context.impl.wrappers.SlowContextualConsumer.accept(SlowContextualConsumer.java:21) at io.smallrye.mutiny.helpers.UniCallbackSubscriber.onItem(UniCallbackSubscriber.java:73) at io.smallrye.mutiny.operators.uni.builders.DefaultUniEmitter.complete(DefaultUniEmitter.java:37) at io.vertx.core.impl.future.FutureImpl$3.onSuccess(FutureImpl.java:137) at io.vertx.core.impl.future.FutureBase.emitSuccess(FutureBase.java:66) at io.vertx.core.impl.future.FutureImpl.addListener(FutureImpl.java:231) at io.vertx.core.impl.future.FutureImpl.onComplete(FutureImpl.java:132) at io.quarkus.reactive.transaction.TransactionalInterceptorBase.lambda$toUni$0(TransactionalInterceptorBase.java:163) at io.smallrye.context.impl.wrappers.SlowContextualConsumer.accept(SlowContextualConsumer.java:21) at io.smallrye.mutiny.operators.uni.builders.UniCreateWithEmitter.subscribe(UniCreateWithEmitter.java:22) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.groups.UniSubscribe.withSubscriber(UniSubscribe.java:51) at io.smallrye.mutiny.groups.UniSubscribe.with(UniSubscribe.java:110) at io.smallrye.mutiny.operators.uni.UniOnTerminationCall$UniOnTerminationCallProcessor.onFailure(UniOnTerminationCall.java:80) at io.smallrye.mutiny.operators.uni.UniOnTerminationCall$UniOnTerminationCallProcessor.lambda$onFailure$3(UniOnTerminationCall.java:82) at io.smallrye.context.impl.wrappers.SlowContextualConsumer.accept(SlowContextualConsumer.java:21) at io.smallrye.mutiny.helpers.UniCallbackSubscriber.onItem(UniCallbackSubscriber.java:73) at io.smallrye.mutiny.operators.uni.UniOnTermination$UniOnTerminationProcessor.onItem(UniOnTermination.java:39) at io.smallrye.mutiny.operators.uni.UniAndCombination$AndSupervisor.computeAndFireTheOutcome(UniAndCombination.java:159) at io.smallrye.mutiny.operators.uni.UniAndCombination$AndSupervisor.check(UniAndCombination.java:137) at io.smallrye.mutiny.operators.uni.UniAndCombination$UniHandler.onItem(UniAndCombination.java:232) at io.smallrye.mutiny.operators.uni.builders.UniCreateFromKnownItem$KnownItemSubscription.forward(UniCreateFromKnownItem.java:42) at io.smallrye.mutiny.operators.uni.builders.UniCreateFromKnownItem.subscribe(UniCreateFromKnownItem.java:23) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.operators.uni.UniAndCombination$UniHandler.subscribe(UniAndCombination.java:245) at io.smallrye.mutiny.operators.uni.UniAndCombination$AndSupervisor.run(UniAndCombination.java:88) at io.smallrye.mutiny.operators.uni.UniAndCombination.subscribe(UniAndCombination.java:53) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.operators.uni.UniOnTermination.subscribe(UniOnTermination.java:21) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.groups.UniSubscribe.withSubscriber(UniSubscribe.java:51) at io.smallrye.mutiny.groups.UniSubscribe.with(UniSubscribe.java:110) at io.smallrye.mutiny.operators.uni.UniOnTerminationCall$UniOnTerminationCallProcessor.onFailure(UniOnTerminationCall.java:80) at io.smallrye.mutiny.operators.uni.UniOperatorProcessor.onFailure(UniOperatorProcessor.java:55) at io.smallrye.mutiny.operators.uni.UniOnCancellationCall$UniOnCancellationCallProcessor.onFailure(UniOnCancellationCall.java:59) at io.smallrye.mutiny.operators.uni.UniOnFailureFlatMap$UniOnFailureFlatMapProcessor.onFailure(UniOnFailureFlatMap.java:65) at io.smallrye.mutiny.operators.uni.UniOnFailureTransform$UniOnFailureTransformProcessor.onFailure(UniOnFailureTransform.java:67) at io.smallrye.mutiny.operators.uni.UniOperatorProcessor.onFailure(UniOperatorProcessor.java:55) at io.smallrye.mutiny.operators.uni.builders.UniCreateFromKnownFailure$KnownFailureSubscription.forward(UniCreateFromKnownFailure.java:42) at io.smallrye.mutiny.operators.uni.builders.UniCreateFromKnownFailure.subscribe(UniCreateFromKnownFailure.java:23) at io.smallrye.mutiny.operators.AbstractUni.subscribe(AbstractUni.java:35) at io.smallrye.mutiny.operators.uni.UniOnItemTransformToUni$UniOnItemTransformToUniProcessor.performInnerSubscription(UniOnItemTransformToUni.java:81) at io.smallrye.mutiny.operators.uni.UniOnItemTransformToUni$UniOnItemTransformToUniProcessor.onItem(UniOnItemTransformToUni.java:57) at io.smallrye.mutiny.operators.uni.UniOnItemConsume$UniOnItemComsumeProcessor.onItem(UniOnItemConsume.java:47) at io.smallrye.mutiny.operators.uni.UniOnItemConsume$UniOnItemComsumeProcessor.onItem(UniOnItemConsume.java:47) at io.smallrye.mutiny.operators.uni.builders.DefaultUniEmitter.complete(DefaultUniEmitter.java:37) at io.vertx.core.impl.future.FutureImpl$3.onSuccess(FutureImpl.java:137) at io.vertx.core.impl.future.FutureBase.emitSuccess(FutureBase.java:66) at io.vertx.core.impl.future.FutureImpl.tryComplete(FutureImpl.java:259) at io.vertx.core.impl.future.FixedMapping.onSuccess(FixedMapping.java:31) at io.vertx.core.impl.future.FutureBase.emitSuccess(FutureBase.java:66) at io.vertx.core.impl.future.FutureImpl.tryComplete(FutureImpl.java:259) at io.vertx.core.Promise.complete(Promise.java:66) at io.vertx.sqlclient.impl.TransactionImpl.lambda$txCommand$2(TransactionImpl.java:154) at io.vertx.core.impl.future.FutureImpl$4.onSuccess(FutureImpl.java:176) at io.vertx.core.impl.future.FutureBase.lambda$emitSuccess$0(FutureBase.java:60) at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173) at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166) at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:569) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:998) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:1474) Suppressed: io.vertx.core.impl.NoStackTraceThrowable: Connection released twice Caused by: io.smallrye.mutiny.CompositeException: Multiple exceptions caught: [Exception 0] java.lang.IllegalStateException: Session/EntityManager is closed [Exception 1] java.lang.NullPointerException: Cannot invoke "io.vertx.sqlclient.Transaction.rollback()" because "transaction" is null ... 95 more Suppressed: java.lang.NullPointerException: Cannot invoke "io.vertx.sqlclient.Transaction.rollback()" because "transaction" is null at io.quarkus.reactive.transaction.TransactionalInterceptorBase.actualRollback(TransactionalInterceptorBase.java:214) at io.quarkus.reactive.transaction.TransactionalInterceptorBase.rollbackOrCommitBasedOnException(TransactionalInterceptorBase.java:210) at io.quarkus.reactive.transaction.TransactionalInterceptorBase.lambda$defineReactiveTransactionalChain$0(TransactionalInterceptorBase.java:92) at io.smallrye.context.impl.wrappers.SlowContextualFunction.apply(SlowContextualFunction.java:21) at io.smallrye.mutiny.groups.UniOnFailure.lambda$call$4(UniOnFailure.java:105) at io.smallrye.context.impl.wrappers.SlowContextualFunction.apply(SlowContextualFunction.java:21) at io.smallrye.mutiny.operators.uni.UniOnFailureFlatMap$UniOnFailureFlatMapProcessor.performInnerSubscription(UniOnFailureFlatMap.java:95) ... 94 more Caused by: java.lang.IllegalStateException: Session/EntityManager is closed at org.hibernate.internal.AbstractSharedSessionContract.checkOpen(AbstractSharedSessionContract.java:576) at org.hibernate.internal.SessionImpl.checkOpen(SessionImpl.java:156) at org.hibernate.engine.spi.SharedSessionContractImplementor.checkOpen(SharedSessionContractImplementor.java:188) at org.hibernate.reactive.session.impl.ReactiveSessionImpl.checkOpen(ReactiveSessionImpl.java:1777) at org.hibernate.reactive.session.impl.ReactiveSessionImpl.reactiveFind(ReactiveSessionImpl.java:1242) at org.hibernate.reactive.session.ReactiveSession.reactiveFind(ReactiveSession.java:96) at org.hibernate.reactive.mutiny.impl.MutinySessionImpl.lambda$find$3(MutinySessionImpl.java:223) at io.smallrye.context.impl.wrappers.SlowContextualSupplier.get(SlowContextualSupplier.java:21) at io.smallrye.mutiny.operators.uni.builders.UniCreateFromCompletionStage.subscribe(UniCreateFromCompletionStage.java:24) ... 87 more ``` Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Address review feedback from cescoffier, yrodiere, and marko-bekhta. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dev MCP: Add initial skill files for 11 core extensions
Updating some code samples Signed-off-by: Michal Maléř <mmaler@redhat.com>
…erence Style and grammar review for the "OpenID Connect (OIDC) and OAuth2 client and filters" guide
…tting Ensure `@Transactional` Unis can be re-executed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )