add config with no exists config

[himrock922]

ref #630

I commit of parameter that was said "unknown" with config.
For example, `The config property 'vnet_default_interface' is unknown`
Because I don't know very well about config detail, I need refactoring it.

This PR related to issue #626

Hi All,
I'm sorry, after rebase execute, confflict code(like as <<<HEAD, ======) mixed PR(Also, reflog failed). So, recreate branch...

Make sure to follow and check these boxes before submitting a PR! Thank you.

• Explain the feature
• Read CONTRIBUTING.md

[gronke]

Hi All,
I'm sorry, after rebase execute, confflict code(like as <<<HEAD, ======) mixed PR(Also, reflog failed). So, recreate branch...

No worries, your set of changes is great to spot the differences to other variants.

Adding the values to the defaults has the effect that ioc does no longer complain about unknown JailConfig properties, but they will just be ignored when processing a jail. There are the cases:

1. A feature is missing in libioc
   1. feature needs to be implemented
   2. config property can be added to Globals
2. An iocage feature is unfortunately named
   1. the value can be mapped to a more reasonable internal name
   2. mapped name is added to the Globals
3. iocage duplicates a feature with other name
   1. ignore the value on read (maybe verify with the other settings, but still ignore it)
   2. calculate the value on configuration write, so that the result remains compatible
4. The iocage feature has design flaws
   1. will not be implemented
   2. warn users with error
   3. a --ignore-compat flag (or similar) can turn the error (2) into a warning and continue

As one with the ideas from your other branch, @himrock922, I'd like to derive more Issues from each individual change you suggest to the Globals. Doing so, while following the workflow described above, will lead to a user friendly solution with minimal breakage for iocage users. (iocage_legacy should not be affected).

[gronke]

Hi @himrock922, the comments I left are a start to implement your suggested changes. Some changes require new features to be implemented, which you can find linked in my comments. If you would create one PR per feature, we can individually discuss and test the implications for libioc.

[gronke]

Interesting idea to actually turn the allow_mount_* properties into booleans. The sysctl value is an integer type, but there is a translation of boolean values happening. We should just be consistent and change similar properties among this one.

[himrock922]

OK. I think should keep a consistency for code(For example, 0 or 1 integer only used, or boolean type only used).
If possible, To refactoring for future, I think should only use boolean type.

[himrock922]

Anyway, I do fix such allow_mount.* parameters from 0,1 to True, False.

[gronke]

This is not a property that can be set. It should not be in the jail configuration at all. Is that the case in python-iocage?

[himrock922]

Yes, such parameters using with python-iocage.
https://www.freebsd.org/cgi/man.cgi?query=iocage&sektion=8

• available
  https://www.freebsd.org/cgi/man.cgi?query=iocage&sektion=8

     available	   Available space in the jail's dataset.  The amount of space
		   available to	the dataset and	all its	children, assuming
		   that	there is no other activity in the pool.	 Because space
		   is shared within a pool, availability can be	limited	by any
		   number of factors, including	physical pool size, quotas,
		   reservations, or other datasets within the pool.

		   Source: zfs(8)

• bpf

https://github.com/iocage/iocage/blob/528f007e92f6e081614d8a09186c4831fc9f3e32/iocage.8#L1019

Toggle starting the jail with Berkely Packet Filter devices enabled.

• compression

https://github.com/iocage/iocage/blob/528f007e92f6e081614d8a09186c4831fc9f3e32/iocage.8#L1724

Controls the compression algorithm used for this dataset.
The lzjb compression algorithm is optimized for performance while
providing decent data compression.
Setting compression to on uses the lzjb compression algorithm.
The gzip algorithm uses the same compression as the

• compressratio

https://github.com/iocage/iocage/blob/528f007e92f6e081614d8a09186c4831fc9f3e32/iocage.8#L1789

Compression ratio.
Read-only.
For non-snapshots, the compression ratio achieved for the used space
of this dataset, expressed as a multiplier.
The used property includes descendant datasets, and, for clones, does
not include the space shared with the origin snapshot.

Also, Also, comment property setting a lower layer for user property.

ref #630 (comment)

For example

user {
  comment: None,
  notes: None
}

[gronke]

There is a new feature suggested in #636 - this change should be handled in a separate PR that addresses the GitHub Issue.

[gronke]

Missing feature tracked in #632 - this change belongs in a separate PR.