MvP-4345 series

[ctnguyen]

This is the group series of PR : MvP-4434 MvP4441 MvP 4443, all items inside the larger issue https://github.com/bitcoin-sv/teranode/issues/4345. Each commit resolve one issue item

[github-actions]

🤖 Claude Code Review

Status: Complete

---

This PR implements multiple Bitcoin SV consensus rules aligned with the C++ bitcoin-sv implementation. The changes improve compliance with the BSV protocol specification.

Summary:

The PR adds several consensus and policy checks:

• Consensus checks (always enforced):
  • Transaction size limits (1MB pre-Genesis, 1GB post-Genesis)
  • Null prevout detection (txid=0 AND index=0xFFFFFFFF)
  • P2SH output ban post-Genesis
  • Pre-Genesis sigops limit (20,000)
• Policy checks (mempool only):
  • Enhanced sigops counting with P2SH redeem script support
  • MaxCoinsViewCacheSize for DoS protection
  • Refined consolidation transaction logic

Strengths:

• Comprehensive test coverage for new features
• Clear separation of consensus vs policy checks
• Detailed documentation matching C++ implementation
• Proper Genesis height handling

No critical issues found. The implementation appears sound with appropriate validation logic and good test coverage.

[sonarqubecloud]

Quality Gate failed

Failed conditions
72.6% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE