Skip to content

feat: add blocks only mode#533

Open
gokutheengineer wants to merge 2 commits intobsv-blockchain:mainfrom
gokutheengineer:gokhan/blocks-only-mode
Open

feat: add blocks only mode#533
gokutheengineer wants to merge 2 commits intobsv-blockchain:mainfrom
gokutheengineer:gokhan/blocks-only-mode

Conversation

@gokutheengineer
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

🤖 Claude Code Review

Status: Complete

Review Summary

This PR adds a BlocksOnly mode to subtree validation that allows nodes to skip processing peer-announced subtrees (via Kafka) while still processing subtrees from blocks. The implementation is clean and well-tested.

No issues found. The code follows project conventions and includes comprehensive test coverage:

  • ✅ Configuration properly wired through settings with documentation
  • ✅ Logic correctly placed after FSM state check
  • ✅ Three test cases covering: blocks-only enabled, blocks-only disabled, and FSM state interaction
  • ✅ Tests use appropriate patterns (testServer with mock injection, atomic.Bool for verification)
  • ✅ Comments explain the "why" behind the feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant