Skip to content

fix(firefox): font might be undefined #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix(firefox): font might be undefined #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/embed-webfonts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ async function parseWebFontRules<T extends HTMLElement>(
}

function normalizeFontFamily(font: string) {
return font.trim().replace(/["']/g, '')
return font?.trim().replace(/["']/g, '')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return font?.trim()?.replace(/["']/g, '')

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I'm not sure if it's needed, only font could be undefined. Trim and replace will not throw errors I guess if it's an empty string

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only undefined will throw exception, and there are the possibilities of font coming as undefined.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I cannot edit my code right now, I hope the maintainer could add this silent fail for fonts in a separate commit then

}

function getUsedFonts(node: HTMLElement) {
Expand Down
Loading