Repository navigation
feat(build): epic mode builds and merges locally, one push per epic - #585
Merged
Merged
Conversation
Feature branches get no PR and no push. The lead merges them into the local epic/<issue> on a green local run. The epic tail commits docs, logbook and version bump locally, then pushes once and opens the epic PR. The verdict block and the teammate's summary go on the sub-issue. ci.yml limits the push trigger to main: push plus pull_request ran each PR commit twice.
This reverts commit f1df73c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
buildepic mode builds and merges on the local machine. The epic branch reaches GitHub once, so CI runs once per epic.Before this PR, each feature pushed a branch and opened a PR into
epic/<issue>. The lead pushedepic/<issue>after each merge.ci.ymlran onpushand onpull_request, so each feature caused about three CI runs.Changes
lore-workflow/skills/build/epic.md: the lead createsepic/<issue>locally and pushes nothing during the build. The lead merges each feature branch after a green local run of the full suite and ruff.lore-workflow/skills/build/teammate-brief.md: the teammate commits, does not push and opens no PR. The teammate posts its summary and the red→green evidence as a sub-issue comment.lore-workflow/skills/build/review.md: inepicmode the review reads--range epic/<issue>..feat/<n>-<slug>. The reviewer posts the verdict block on the sub-issue. The whole-epic verdict goes on the epic issue.lore-workflow/skills/build/epic-tail.md: ledger, docs, whole-epic review, logbook entry and version bump are local commits. Then the lead runs the suite once more, pushes once and opens the epic PR..github/workflows/ci.yml: thepushtrigger is limited tomain. A PR commit runs CI once.docs/how-to/run-an-epic.md,docs/conventions.md: one line each.What stays on GitHub
Known limits
epic/<issue>.epic.mdnames this exception.CHANGELOG.md, entry "buildepic mode stops waiting for CI per feature"). This PR ends that. No ADR records the change.Checks
tests/test_workflow_build_skill.py::test_an_epic_reaches_the_remote_onceand::test_ci_runs_once_per_pr_pushare new. Both failed before the skill edits.pytest -q: 2502 passed, 1 failed.tests/test_skill_cli_drift.py::test_lore_cli_top_level_verbs_match_skill_invocationsfails onmaintoo in the local shell: the test calls a barepythonthat lackslore_cli.