Refactor/restructure injection to match modularisation and allow multiple ViewModels #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaTriXy
approved these changes
Nov 29, 2017
hitherejoe
reviewed
Dec 18, 2017
| @@ -3,6 +3,7 @@ package org.buffer.android.boilerplate.ui.injection.module | |||
| import android.app.Application | |||
| import android.content.Context | |||
| import com.nhaarman.mockito_kotlin.mock | |||
| import dagger.Binds | |||
There was a problem hiding this comment.
there are a lot of unused imports here that could be removed :)
hitherejoe
reviewed
Dec 18, 2017
| @@ -4,6 +4,7 @@ import android.app.Application | |||
| import android.arch.lifecycle.ViewModelProvider | |||
| import android.arch.persistence.room.Room | |||
| import android.content.Context | |||
| import dagger.Binds | |||
There was a problem hiding this comment.
unused imports here also!
hitherejoe
reviewed
Dec 18, 2017
| abstract class DataModule { | ||
|
|
||
| @Binds | ||
| abstract fun bindBufferooRepository(bufferooDataRepository: BufferooDataRepository): BufferooRepository |
There was a problem hiding this comment.
this line is too long, maybe break it before BufferooRepository?
|
Happy to merge this with the above changes :) Thanks @anstaendig 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was started to support multiple ViewModels via a Provider as stated in #4. After reading https://medium.com/square-corner-blog/keeping-the-daggers-sharp-%EF%B8%8F-230b3191c3f I did some restructuring and refactoring regarding the dependency injection in general. If one would believe the aforementioned article then this approach should be more performant. I also had the idea to split up the modules to match the modularisation. That means that all dependencies from inside the data module are provided/bound by
DataModuleand so on. Let me know what you think.