Skip to content

Added New phase for NDK Plugin checks. - #2427

Open
SB-sachinp wants to merge 4 commits into
nextfrom
sachin/plat-16581-custom-build-mercado
Open

SB-sachinp wants to merge 4 commits into
nextfrom
sachin/plat-16581-custom-build-mercado

Conversation

@SB-sachinp

@SB-sachinp SB-sachinp commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

In the diagnostic snapshot, we added phase-level instrumentation for NDK plugin load:

  • plugin_init
  • library_resolve
  • load_library
  • link_native
  • post_init

Each phase emits structured fields:

  • phase_start_ns
  • phase_end_ns
  • phase_duration_ns
  • thread_name
  • is_main_thread
  • outcome (ok / error)
  • error_class (only on error)

Plus an extra resolve check to improve root-cause quality:

  • resolved_library_path
  • resolved_library_exists

This gives exact failure/latency location instead of one opaque startup block.

  • Improves NDK load diagnostics to split queue_wait_ns, native_load_ns, and caller_blocked_ns, making delays easier to attribute.
  • Adds explicit retry reporting for native load (load_retry_attempted, load_retry_succeeded, first/second attempt outcomes).
  • Captures original linker error message(s) alongside error class to better diagnose ABI/dependency/ELF/linker issues.
  • Enhances library path diagnostics with mapped name, source (nativeLibraryDir vs fallback), confidence (definitive), file existence, and optional size.

@bugsnagbot

bugsnagbot commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1851.75 1608.66
arm64_v8a 659.71 413.95
armeabi_v7a 598.28 352.52
x86 729.33 483.57
x86_64 704.76 459.0

Generated by 🚫 Danger

SB-adityap
SB-adityap previously approved these changes Jun 5, 2026

@SB-adityap SB-adityap left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SB-jigneshR SB-jigneshR added the wip There is work in progress label Jun 5, 2026
@SB-jigneshR
SB-jigneshR marked this pull request as ready for review June 8, 2026 12:14

@SB-jigneshR SB-jigneshR left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking as it has specific changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wip There is work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants