Handle request and response in delivery-react-native#2667
Draft
gingerbenw wants to merge 5 commits intonextfrom
Draft
Handle request and response in delivery-react-native#2667gingerbenw wants to merge 5 commits intonextfrom
gingerbenw wants to merge 5 commits intonextfrom
Conversation
gingerbenw
force-pushed
the
react-native-delivery-request-response
branch
from
e473b24 to
285c39b
Compare
gingerbenw
force-pushed
the
react-native-delivery-request-response
branch
10 times, most recently
from
7f980b9 to
7c227bc
Compare
gingerbenw
changed the title
gingerbenw
changed the title
…o improve performance
gingerbenw
force-pushed
the
react-native-delivery-request-response
branch
from
a0cf645 to
3616850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Handle
requestandresponsein@bugsnag/delivery-react-nativeand ensure the values are correct on both iOS and AndroidThis PR also refactors the URL parsing in
plugin-network-instrumentationto be more performant by separating out the domain, url and query string in a single pass rather than manipulating the string in multiple methodsTesting
Update E2E tests to check
bodyLengthandstatusCodeare integersUpdate unit tests for url parsing functionality