Skip to content

Handle request and response in delivery-react-native#2667

Merged
gingerbenw merged 5 commits intonextfrom
react-native-delivery-request-response
Mar 30, 2026
Merged

Handle request and response in delivery-react-native#2667
gingerbenw merged 5 commits intonextfrom
react-native-delivery-request-response

Conversation

@gingerbenw
Copy link
Copy Markdown
Member

@gingerbenw gingerbenw commented Jan 30, 2026

Goal

Handle request and response in @bugsnag/delivery-react-native and ensure the values are correct on both iOS and Android

This PR also refactors the URL parsing in plugin-network-instrumentation to be more performant by separating out the domain, url and query string in a single pass rather than processing the string in multiple stages

Testing

Update E2E tests to check bodyLength and statusCode are integers
Update unit tests for url parsing functionality

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 30, 2026

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 51.65 kB 15.26 kB
After 51.65 kB 15.26 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 7285573

Base automatically changed from test/react-native-http-errors to next February 2, 2026 10:21
@gingerbenw gingerbenw force-pushed the react-native-delivery-request-response branch from e473b24 to 285c39b Compare February 6, 2026 14:20
@gingerbenw gingerbenw force-pushed the react-native-delivery-request-response branch 10 times, most recently from 7f980b9 to 7c227bc Compare March 20, 2026 17:50
@gingerbenw gingerbenw changed the title feat: ✨ handle request and response object in delivery-react… Handle request and response object in delivery-react-native Mar 24, 2026
@gingerbenw gingerbenw changed the title Handle request and response object in delivery-react-native Handle request and response in delivery-react-native Mar 24, 2026
@gingerbenw gingerbenw force-pushed the react-native-delivery-request-response branch from a0cf645 to 3616850 Compare March 24, 2026 15:28
@gingerbenw gingerbenw force-pushed the react-native-delivery-request-response branch from 3616850 to 7285573 Compare March 27, 2026 09:29
@gingerbenw gingerbenw marked this pull request as ready for review March 27, 2026 10:27
@gingerbenw gingerbenw changed the base branch from next to bumpsnag-bugsnag-cocoa-v6.36.0 March 27, 2026 10:57
Base automatically changed from bumpsnag-bugsnag-cocoa-v6.36.0 to next March 27, 2026 14:41
Copy link
Copy Markdown
Contributor

@hamudi-ahmed hamudi-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gingerbenw gingerbenw merged commit 3caa7da into next Mar 30, 2026
48 checks passed
@gingerbenw gingerbenw deleted the react-native-delivery-request-response branch March 30, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants