Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): explicitly derive Message trait #2127

Conversation

Szymongib
Copy link
Contributor

@Szymongib Szymongib commented Oct 29, 2021

Current Behaviour

Currently Message trait is implicitly derived for all types that implement Serialize and DeserializeOwned traits.

Proposed Changes

Require explicit derive of Message trait for custom types for additional type safety guarantee when sending messages.

Fixes: #1849

Checks

@Szymongib Szymongib force-pushed the explicit-derive-of-message-trait branch 2 times, most recently from 8eacddc to f8afc20 Compare October 29, 2021 16:29
@@ -0,0 +1,176 @@
Apache License
Copy link
Member

@mrinalwadhwa mrinalwadhwa Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a relative link to the ockam license file instead of a copy of the license.

@mrinalwadhwa
Copy link
Member

mrinalwadhwa commented Oct 30, 2021

Thank you for sending the PR ❤️

Before we can merge, please:

Looking forward to merging your first contribution!!

@jdspdx
Copy link
Contributor

jdspdx commented Nov 1, 2021

Thanks for your contribution! I've rebased and merged these commits in #2137

@jdspdx jdspdx closed this Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop deriving Message trait implementation for all Serialize&Deserialize structs
4 participants