Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elixir): cbor library and mini_cbor map optimization #2711

Merged
merged 1 commit into from
May 5, 2022
Merged

feat(elixir): cbor library and mini_cbor map optimization #2711

merged 1 commit into from
May 5, 2022

Conversation

hairyhum
Copy link
Contributor

@hairyhum hairyhum commented May 5, 2022 •
edited
Loading

Current Behaviour

There is a number of issues with current message encoding format is discussed in #2496

Proposed Changes

This PR adds CBOR library and mini_cbor map optimization.

Addresses #2687

Checks

@hairyhum hairyhum requested a review from a team as a code owner May 5, 2022 18:50
mrinalwadhwa
mrinalwadhwa previously approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@mrinalwadhwa mrinalwadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@hairyhum hairyhum requested a review from mrinalwadhwa May 5, 2022 21:19
@hairyhum hairyhum merged commit d00bb6a into develop May 5, 2022
@hairyhum hairyhum mentioned this pull request May 9, 2022
Closed
@hairyhum hairyhum deleted the hairyhum/cbor branch June 3, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrinalwadhwa mrinalwadhwa mrinalwadhwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hairyhum @mrinalwadhwa