Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): add rendezvous service for nat hole punching #4489

Merged
merged 1 commit into from
Mar 27, 2023
Merged

feat(rust): add rendezvous service for nat hole punching #4489

merged 1 commit into from
Mar 27, 2023

Conversation

neil2468
Copy link
Contributor

Proposed changes

This is part of the prototype for UDP NAT Hole Punching (#3507).

  • Add a 'Rendezvous service' to the UDP transport.
  • Add tests to exercise new code.

Thanks!

Checks

@neil2468 neil2468 requested a review from a team as a code owner March 18, 2023 17:20
@mrinalwadhwa
Copy link
Member

@neil2468 This looks awesome. Did you happen to test it across NATs somehow?

@neil2468
Copy link
Contributor Author

@mrinalwadhwa Thanks. I've not yet tried setting up an evironment for NAT testing, but now that you mention it maybe I should do that next.

This PR does not implement hole punching yet, it's only adds the Rendezvous service which will maintain a table of the public IPs of remote nodes.

davide-baldo
davide-baldo previously approved these changes Mar 21, 2023
Copy link
Member

@davide-baldo davide-baldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@etorreborre etorreborre added this pull request to the merge queue Mar 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2023
@mrinalwadhwa mrinalwadhwa added this pull request to the merge queue Mar 27, 2023
Merged via the queue into build-trust:develop with commit 5a4e3d1 Mar 27, 2023
@neil2468 neil2468 deleted the neil2468/udp_natholepunch branch May 12, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants