Use Agent API for locking mirrors and known_hosts #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
pdp-1075-use-lock-service-2
branch
from
7467471 to
432c3cf
Compare
DrJosh9000
changed the title
DrJosh9000
changed the title
DrJosh9000
force-pushed
the
pdp-1075-use-lock-service-2
branch
from
432c3cf to
73cbd09
Compare
DrJosh9000
force-pushed
the
pdp-1075-use-lock-service-2
branch
from
73cbd09 to
97a4fdf
Compare
moskyb
reviewed
Jul 11, 2023
Contributor
moskyb
left a comment
moskyb
left a comment
There was a problem hiding this comment.
i like this but.... a post on the community slack reminded me that we probably can't use the agent locking service for locking mirrors, as mirrors are sharable through [E|Z]FS, and mirror locks through the agent API wouldn't be propagated through to the other users of the shared git mirror :/
Contributor
Author
|
Perhaps the choice of "lock providers" should be configurable? Oooh. What about making it a hook? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Agent API experiment is enabled and working, then shell will now use it for locking instead of
flock.At least two reasons for this: