-
Notifications
You must be signed in to change notification settings - Fork 6
maintenance: upgrade to TypeScript 5, Oclif 4, node 18+ #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6880385
maintenance: major upgrade of all packages notably TS & Oclif
paulRbr 5cec811
maintenance: full rewrite for oclif 4 (and typescript 5)
paulRbr cce84ae
fix: make sure API definition class is compatible with windows
paulRbr e7b2e12
CI: minimal version of node is now v20
paulRbr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "extends": [ | ||
| "plugin:@typescript-eslint/recommended", | ||
| "oclif", "oclif-typescript", | ||
| "prettier", | ||
| "plugin:prettier/recommended" | ||
| ], | ||
| "rules": { | ||
| "camelcase": "off", | ||
| "padding-line-between-statements": [ | ||
| "error", | ||
| { "blankLine": "always", "prev": "multiline-expression", "next": "multiline-expression" } | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,15 @@ | ||
| *-debug.log | ||
| *-error.log | ||
| /.nyc_output | ||
| **/.DS_Store | ||
| /.idea | ||
| /dist | ||
| /lib | ||
| *oclif.manifest.json | ||
| /tmp | ||
| /yarn.lock | ||
| node_modules | ||
| /node_modules | ||
| oclif.manifest.json | ||
|
|
||
|
|
||
|
|
||
| yarn.lock | ||
| pnpm-lock.yaml | ||
|
|
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "require": [ | ||
| "ts-node/register", | ||
| "./test/helpers/init.ts" | ||
| ], | ||
| "watch-extensions": [ | ||
| "ts" | ||
| ], | ||
| "recursive": true, | ||
| "reporter": "spec", | ||
| "timeout": 60000, | ||
| "node-option": [ | ||
| "loader=ts-node/esm", | ||
| "experimental-specifier-resolution=node", | ||
| "no-warnings=ExperimentalWarning" | ||
| ] | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| "@oclif/prettier-config" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "type": "node", | ||
| "request": "attach", | ||
| "name": "Attach", | ||
| "port": 9229, | ||
| "skipFiles": ["<node_internals>/**"] | ||
| }, | ||
| { | ||
| "type": "node", | ||
| "request": "launch", | ||
| "name": "Execute Command", | ||
| "skipFiles": ["<node_internals>/**"], | ||
| "runtimeExecutable": "node", | ||
| "runtimeArgs": ["--loader", "ts-node/esm", "--no-warnings=ExperimentalWarning"], | ||
| "program": "${workspaceFolder}/bin/dev.js", | ||
| "args": ["hello", "world"] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| @echo off | ||
|
|
||
| node --loader ts-node/esm --no-warnings=ExperimentalWarning "%~dp0\dev" %* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #!/usr/bin/env -S node --loader ts-node/esm --disable-warning=ExperimentalWarning | ||
|
|
||
| // eslint-disable-next-line n/shebang | ||
| import {execute} from '@oclif/core' | ||
|
|
||
| await execute({development: true, dir: import.meta.url}) |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| import {execute} from '@oclif/core' | ||
|
|
||
| await execute({dir: import.meta.url}) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in readme we wrote in v20 minimum
https://github.com/bump-sh/cli/pull/587/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R35
Does it mean we should remove node_version 18 here?