Some improvements. Fixed the viewmodel snapping around when turning quickly. #8
Conversation
Fixed indentation to four spaces instead of tabs
|
No worries. I'll take a look at the changes in this PR instead 🙂 |
|
Sorry for spamming if these messages going to your email, but still gonna say - there's nothing different, other than there being four spaces instead of tabs. |
Since my changes aren't gonna get merged that quickly, releasing this! :D
...of things that made me question Buu's sanity
-for people to have fun with.
buu342
left a comment
buu342
left a comment
There was a problem hiding this comment.
I would rather weapons not be bundled with the weapon base.
...was inconsistent because Notepad++ is hellbent on tabs and Buu loves four spaces.
I would recommend you include them. If you don't, that's fine. But regardless, here are some reasons to do include them.
P.S. I am gonna be resolving the spacing issues without any commentary from now on. Because they're just spacing issues. Notepad++, "Find in Files", "\garrysmod\addons\GMod-BuuBaseRedone-Improved\lua", "Search Mode" "Regular expression", "Find what :" "\t", "Replace with :", " |
The crosshair spread is actually static. So that makes the crosshair inaccurate when moving. Also fixed the crosshair to display correct spread. There are probably left variables I didn't remove!
Now the curve only happens when you jump. That, and some other optimizations.
|
I've did everything now. Weapons aren't bundled with the base, jumping animation only plays when actually jumping (I still think this is stupid), and... that's pretty much it. |
Now it's fixed.
|
Welp, fixed that now! :D |
|
Now I'm truly done! |
|
Sorry for spamming (if this counts as it), and again, I'm not trying to get you to hurry, but... are you still alive? /j |
|
Now I know that you're alive since you starred that one repository lol |
|
Like I said, this PR makes a lot of changes, some which I agree and some which I don't. It will take me an entire afternoon to properly review the code and bisect changes that I want. Frankly, I haven't had the time nor patience to do that, and I do not know when I will. I haven't touched Garry's Mod since October. |
|
Not a problem, not forcing you to hurry. It's just that you disappeared from everywhere for a lot of time lol |
2 participants
Why did I close and now am reopening the pull request? Because GitHub did some BS which made it self-close. I didn't close it. It just... did that. Somewhy. I really don't know. So now opening another one...
Now, about your points as stated here.