fix: uses alternative method to open files on windows with shared permissions#136

Closed

MagnetoMallard wants to merge 17 commits intobuu342:masterfrom

MagnetoMallard:windows-shared-file-fix

Commits on Mar 21, 2025

Commits on Mar 22, 2025

fix: its possible we actually needed that share header
MagnetoMallard
committed
experiment: experimenting with a different way of opening files under windows to allow for rom replacement. no idea if it will work, here goes a PR build.
MagnetoMallard
committed
woops: thats not how you include cpp headers
MagnetoMallard
committed
fix: sorting out missing includes and such
MagnetoMallard
committed
fix: boldly assuming that this macro exists in whichsomever version of MSVC is compiling this
MagnetoMallard
committed
no luck on that macro! trying something else!
MagnetoMallard
committed
turns out we maybe should use CreateFileA instead, which takes a char rather than tchar filename string
MagnetoMallard
committed
could it be that missing b? its more likely than you think!
MagnetoMallard
committed
i am not sure that stream is needed
MagnetoMallard
committed
nontheless, lets close the handle
MagnetoMallard
committed
the change to the cic check part could actually be breaking things, according to my vibes based calcuation
MagnetoMallard
committed
ah. turns out it will need to be a wide string, as the project is set to use unicode. Weve done the conversion more simply this time
MagnetoMallard
committed
was using the wonderfully named mbstowcs wrong.
MagnetoMallard
committed

Commits on Mar 23, 2025

conceptually, this should all be fine and work merrily now, but it still locks the file :(
MagnetoMallard
committed

Commits on Mar 31, 2025

Merge branch 'buu342:master' into windows-shared-file-fix
MagnetoMallard
authored