Do not interpret TFTP filename as absolute url. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks alright - thanks! I'll give it a spin on my side, hopefully today or tomorrow, and will merge it after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
-http-append-pathTFTP request//foo/bardiscars path portion of base url andhttp://foo/barmade request to serverfoocompletely ignoring base url.This patch validates base url on start and does not interpret TFTP filename in any special way.
It just strips all leading slashes and appends it to base url when
-http-append-pathis enabled.Reproducing error on previous version of tftp-http-proxy:
curl tftp://localhost/http://example.com/(provided that tftp-http-proxy has access to internet).