sync iwasm between windows and posix a bit #4593
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamt
requested review from
loganek,
lum1n0us,
no1wudi,
TianlongLiang,
wenyongh and
xujuntwt95329
as code owners
|
can anyone familiar with windows test this? i haven't tested at all. i guess we should improve the CI coverage for windows. |
this commit includes: * update windows for * WASM_MEM_ALLOC_WITH_USAGE * InstantiationArgs2 * --jit-codecache-size * --disable-bounds-checks * wasm_proposal_print_status * fix WASM_ENABLE_SHARED_HEAP for windows (bytecodealliance#4592) * cosmetic changes to reduce the diff
lum1n0us
reviewed
Sep 2, 2025
| printf(" --repl Start a very simple REPL (read-eval-print-loop) mode\n" | ||
| " that runs commands in the form of `FUNC ARG...`\n"); | ||
| #if WASM_CONFIGURABLE_BOUNDS_CHECKS != 0 | ||
| printf(" --disable-bounds-checks Disable bounds checks for memory accesses\n"); | ||
| #endif |
There was a problem hiding this comment.
It has raised and will continue to raise significant security concerns(out of sandbox) from the BA TSC, so we should avoid exposing it with a CLI option unless absolutely necessary.
There was a problem hiding this comment.
i agree this is a misfeature.
but in any case it should be consistent between windows and posix. (and this PR is about it)
There was a problem hiding this comment.
i filed an issue. #4599
|
the CI failure looks like #4316 |
lum1n0us
approved these changes
Sep 5, 2025
lum1n0us
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit includes:
update windows for
fix WASM_ENABLE_SHARED_HEAP for windows (WASM_ENABLE_SHARED_HEAP for windows cli seems broken #4592)
cosmetic changes to reduce the diff