Inline {enter,exit}_sync_call trampolines into sync-to-sync fused adapters#13695
Merged
fitzgen merged 17 commits intoJun 26, 2026
Conversation
github-actions
Bot
added
the
wasmtime:api
alexcrichton
approved these changes
Jun 22, 2026
alexcrichton
left a comment
alexcrichton
left a comment
Member
There was a problem hiding this comment.
Actually I'll go ahead and flag this for merge. One thing I'd recommend, if you can, is to get an LLM review locally as well to double-check this signs off with no known bugs. If nothing materially changes from my suggestions/comments though seems fine to land.
fitzgen
force-pushed
the
inline-enter-exit-sync-call-in-sync-to-sync-adapters
branch
2 times, most recently
from
00b1e84 to
63b1449
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
fitzgen
force-pushed
the
inline-enter-exit-sync-call-in-sync-to-sync-adapters
branch
from
c0302e3 to
fe5b1e1
Compare
This commit inlines fast paths for the `{enter,exit}_sync_call` component
trampolines in sync-to-sync fused adapters. For cross-component calls of trivial
functions, after inlining, we should avoid all calls in the fused adapter (other
than the `trap` libcall when `may_leave` is set).
The inlining happens during translation, rather than via the regular inliner,
since the lazy thread is stack-allocated within the fused adapter; there would
otherwise be no easy way to reference it.
Fixes bytecodealliance#12311
fitzgen
force-pushed
the
inline-enter-exit-sync-call-in-sync-to-sync-adapters
branch
from
6974e54 to
87c74a8
Compare
Merged
via the queue into
bytecodealliance:main
with commit Jun 26, 2026
946f763
388 of 390 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each commit for details.