fix p3 request.set-authority rejecting ipv6 literal authorities#13739
Merged
pchickey merged 1 commit intoJun 26, 2026
Merged
Conversation
pchickey
approved these changes
Jun 26, 2026
pchickey
left a comment
Contributor
There was a problem hiding this comment.
Thanks, I have now learned something disappointing about the http::Authority parser that I had higher expectations of. Fix much appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: in WASIp3, call
request.set-authoritywith a bracketed IPv6 literal that has no explicit port, for example[::1]or[2001:db8::1]. The call returns an error and the authority is never set.Cause: the validation detects whether a port was supplied with
authority.contains(':')before checking that the port parses. That is also true for the colons inside an IPv6 literal host, so the later "port present but not a valid number" guard fires and a perfectly valid IPv6 authority is rejected unless a port is also appended.Fix: look for the port only after any closing
], so colons inside the IPv6 host are not mistaken for a port. A genuinely malformed port such asexample.com:orexample.com:abcis still rejected. The check moved into a smallparse_authorityhelper with unit tests for the host-name, IPv4, and bracketed IPv6 forms.