fix: no_std fix use without unwind
#9977
Conversation
github-actions
bot
added
cranelift
| let caller_sp_to_cfa_offset = | ||
| crate::isa::unwind::systemv::caller_sp_to_cfa_offset(); | ||
| #[cfg(not(feature = "unwind"))] | ||
| let caller_sp_to_cfa_offset = 0; // TODO is this right? |
There was a problem hiding this comment.
Maybe compute_value_labels_ranges should be made to return ValueLabelsRanges::default(); when the unwind feature is disabled? Except for values which just so happen to be in registers, I don't think it is possible to generate valid debuginfo for locals when the unwind table is not also emitted.
There was a problem hiding this comment.
Arguably, the register values are just as 'meaningless' in the no-unwind case as you need the unwind info to recover them (unless you are willing to disassemble code to guide your unwinder). Ultimately, the debug info production 'feature' is tightly coupled to the unwinding feature.
There was a problem hiding this comment.
I marked compute_value_labels_ranges as available with the unwind feature too and made the Default changes at its only callsite, I think that's clearer than having the function exist but return a meaningless default value.
As part of no_std support in cranelift this PR fixes uses of the
isa/unwindmodule throughcraneliftso thatcraneliftcan be compiled with theunwindfeature (which depends onstdlibthroughgimli) disabled.