Skip to content

Item api bugfixes#4

Merged
LiYanjun19 merged 6 commits into26.Q1.02from
ItemAPI-bugfixes
Feb 24, 2026
Merged

Item api bugfixes#4
LiYanjun19 merged 6 commits into26.Q1.02from
ItemAPI-bugfixes

Conversation

@JonahCWilson
Copy link

@JonahCWilson JonahCWilson commented Feb 18, 2026

Testing Instructions:

  1. Load ADB with 26.Q1.01
  2. Grab an id for a grouped work from solr
  • Sample Id from solr: 03b491ed-5552-afbe-1eb5-d0f2493c6f96-eng
  1. Update IPAddress.php -> allowAPIAccessForClientIP() to return true. (testing only, revert this change)
  2. Attempt to call:
  • /API/ItemAPI?method=getItem&id={id}
  • /API/ItemAPI?method=getBasicItemInfo&id={id}

You'll get a failure.

Apply patch and repeat, you should receive a successful response.

kidclamp and others added 2 commits February 18, 2026 08:37
…etItem

    This patch tries to match the fields used to the fields fetched and
    ensure all necessary data is present

    To test:
    1 - Ensure your IP is allowed to use the API
    2 - Try to fetch a grouped work item, example:
        http://localhost:8083/API/ItemAPI?method=getItem&id=4414b826-a925-c043-0a02-cdb69035a4c0-eng
    3 - Note error in log:

    [Thu Feb 12 16:57:58.425616 2026] [proxy_fcgi:error] [pid 120:tid 131] [client 172.19.0.1:45440] AH01071: Got error 'PHP message: PHP Warning:  Undefined array key "recordtype" in /usr/local/aspen-discovery/code/web/RecordDrivers/RecordDriverFactory.php on line 30; PHP message: PHP Warning:  Undefined array key "recordtype" in /usr/local/aspen-discovery/code/web/RecordDrivers/RecordDriverFactory.php on line 35'

    4 - Apply patch
    5 - Reload the URL
    6 - Confirm record displays
@JonahCWilson JonahCWilson changed the base branch from 26.Q1.01 to 26.Q1.02 February 18, 2026 18:10
@LiYanjun19 LiYanjun19 merged commit 575f068 into 26.Q1.02 Feb 24, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants