Bump lodash.mergewith from 4.6.0 to 4.6.2 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [lodash.mergewith](https://github.com/lodash/lodash) from 4.6.0 to 4.6.2. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/commits) Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
kylemhall
force-pushed
the
bywater-v19.05.04-07
branch
24 times, most recently
from
9ee3246 to
72cce82
Compare
kylemhall
pushed a commit
that referenced
this pull request
Dec 3, 2020
This patch adds the 'cross_fields' type to our searches: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/query-dsl-query-string-query.html#query-string-syntax Without this patch the search terms seem to all require being in the same field when using Elasticsearch 6 To test: 0 - Set QueryAutoTruncate to 'only if * is added' 1 - Find a record with a title and publisher 2 - Search for a word form the title and confirm the record is returned 3 - Search for a work from the title and the publisher's name 4 - The record is not returned 5 - Apply patch 6 - Repeat #3 7 - The record is returned Signed-off-by: Victor Grousset/tuxayo <[email protected]> Signed-off-by: Joonas Kylmälä <[email protected]>
kylemhall
pushed a commit
that referenced
this pull request
Dec 4, 2020
This patch adds the 'cross_fields' type to our searches: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/query-dsl-query-string-query.html#query-string-syntax Without this patch the search terms seem to all require being in the same field when using Elasticsearch 6 To test: 0 - Set QueryAutoTruncate to 'only if * is added' 1 - Find a record with a title and publisher 2 - Search for a word form the title and confirm the record is returned 3 - Search for a work from the title and the publisher's name 4 - The record is not returned 5 - Apply patch 6 - Repeat #3 7 - The record is returned Signed-off-by: Victor Grousset/tuxayo <[email protected]> Signed-off-by: Joonas Kylmälä <[email protected]>
kylemhall
pushed a commit
that referenced
this pull request
Jan 15, 2021
This patch adds the 'cross_fields' type to our searches: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/query-dsl-query-string-query.html#query-string-syntax Without this patch the search terms seem to all require being in the same field when using Elasticsearch 6 To test: 0 - Set QueryAutoTruncate to 'only if * is added' 1 - Find a record with a title and publisher 2 - Search for a word form the title and confirm the record is returned 3 - Search for a work from the title and the publisher's name 4 - The record is not returned 5 - Apply patch 6 - Repeat #3 7 - The record is returned Signed-off-by: Victor Grousset/tuxayo <[email protected]> Signed-off-by: Joonas Kylmälä <[email protected]> Signed-off-by: Jonathan Druart <[email protected]> (cherry picked from commit 03f15d1) Signed-off-by: Andrew Fuerste-Henry <[email protected]>
kylemhall
pushed a commit
that referenced
this pull request
Mar 3, 2022
Throughout the file we call methods with the module Following suit rather than importing the methods To test: 1 - Attempt to load advanced cataloging editor 2 - it fails 3 - http://localhost:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define 4 - Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_svc_cataloguing_framework::GetMarcStructure called at /kohadevbox/koha/svc/cataloguing/framework line 18 5 - Apply patch 6 - Cataloging editor loads! 7 - Link in #3 loads! Signed-off-by: David Nind <[email protected]> Signed-off-by: Jonathan Druart <[email protected]>
kylemhall
pushed a commit
that referenced
this pull request
Aug 19, 2022
The default collection code set in the subscription will be applied if item records are created when receiving the serial. Test plan: 1. Apply 3 patches 2. Run updatedatabase.pl and restart services 3. Create a subscription: - Tick the 'Create an item record when receiving this serial' radio button - Select values in the Location, Collection code and Item type dropdowns - Save the subscription 4. Confirm the Location, and Collection code default values you choose in #3 are displaying in the 'Information' tab of page that's loaded 5. Receive the serial: - Click 'Receive' - Change the status dropdown from 'Expected' to 'Arrived' - Confirm the 'Collection Code', 'Shelving location' and 'Koha item type' dropdowns are pre-filled with the values you defined in #3 6. Run unit test t/db_dependent/Serials.t Sponsored-By: Brimbank Library, Australia Signed-off-by: Samu Heiskanen <[email protected]> Signed-off-by: Andrew Fuerste-Henry <[email protected]> Signed-off-by: Owen Leonard <[email protected]> Signed-off-by: Katrin Fischer <[email protected]> Signed-off-by: Fridolin Somers <[email protected]>
kylemhall
pushed a commit
that referenced
this pull request
Aug 8, 2023
…atatables Test plan: * Create 3 agreements, agreement #1 named 'a', agreement #2 named 'c' and agreement #3 named 'b'. * Go to agreements list, click the Name column header, notice how the agreements get sorted by id #, not by first char in name. Expected order would be abc or cba, but it's acb or bca. * Apply patch, on k-t-d, run the following if you're not using 'yarn js:watch': yarn js:build * Sort the list again on the 'name' column, notice how it now sorts alphabetically as expected, either abc or cba. Signed-off-by: Jonathan Druart <[email protected]> Signed-off-by: Tomas Cohen Arazi <[email protected]> (cherry picked from commit f3cc00d) Signed-off-by: Martin Renvoize <[email protected]> (cherry picked from commit 1009fc1) Signed-off-by: Matt Blenkinsop <[email protected]>
kylemhall
pushed a commit
that referenced
this pull request
Feb 28, 2025
This patch makes the `_process_mappings()` method split the index values in the event of them being bigger than the allowed 32766 bytes size. To test: 1. Have KTD running with ES: $ ktd --proxy --es7 up -d 2. Perform a search 3. Pick the first result for edition 4. Find a cool Wiki page with lots of paragraphs 5. Copy all of the paragraphs and put them on a 500$a field for the record. 6. Repeat 2 => FAIL: The record is not found 7. Reindex manually: $ ktd --shell k$ perl misc/search_tools/rebuild_elasticsearch.pl --biblios --where "biblionumber=3" -v -v => FAIL: You get something like: ``` [22229] Committing final records... One or more ElasticSearch errors occurred when indexing documents at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 148. [22229] There were errors during indexing Record #3 Document contains at least one immense term in field="note.raw" (whose UTF8 encoding is longer than the max length 32766), all of which were skipped. Please correct the analyzer to not produce such terms. The prefix of the first immense term is: '[10, 109, 117, 115, 116, 97, 102, 97, 32, 102, 117, 101, 32, 101, 108, 32, 115, 101, 103, 117, 110, 100, 111, 32, 104, 105, 106, 111, 32, 100]...', original message: bytes can be at most 32766 in length; got 32771 (illegal_argument_exception) : max_bytes_length_exceeded_exception (bytes can be at most 32766 in length; got 32771) [22229] Total 1 records indexed ``` 8. Apply this patch 9. Repeat 7 => SUCCESS: No error! 10. Repeat 2 => SUCCESS: The record is indexed and can be found! 11. Sign off :-D Signed-off-by: Nick Clemens <[email protected]> Signed-off-by: David Cook <[email protected]> Signed-off-by: Katrin Fischer <[email protected]> (cherry picked from commit 6998f5b) Signed-off-by: Paul Derscheid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps lodash.mergewith from 4.6.0 to 4.6.2.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot ignore this [patch|minor|major] versionwill close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.