Skip to content

Make some const public #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hedii wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make some const public #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Gelf/Transport/HttpTransport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@
*/
class HttpTransport extends AbstractTransport
{
private const DEFAULT_HOST = "127.0.0.1";
private const DEFAULT_PORT = 12202;
private const DEFAULT_PATH = "/gelf";
private const AUTO_SSL_PORT = 443;
public const DEFAULT_HOST = "127.0.0.1";
public const DEFAULT_PORT = 12202;
public const DEFAULT_PATH = "/gelf";
public const AUTO_SSL_PORT = 443;

private StreamSocketClient $socketClient;

Expand Down Expand Up @@ -70,12 +70,12 @@ public function __construct(
public static function fromUrl(string $url, ?SslOptions $sslOptions = null): self
{
$parsed = parse_url($url);

// check it's a valid URL
if (false === $parsed || !isset($parsed['host']) || !isset($parsed['scheme'])) {
throw new \InvalidArgumentException("$url is not a valid URL");
}

// check it's http or https
$scheme = strtolower($parsed['scheme']);
if (!in_array($scheme, ['http', 'https'])) {
Expand All @@ -90,7 +90,7 @@ public static function fromUrl(string $url, ?SslOptions $sslOptions = null): sel
$sslOptions = $sslOptions ?: new SslOptions();
$defaults['port'] = 443;
}

// merge defaults and real data and build transport
$parsed = array_merge($defaults, $parsed);
$transport = new self($parsed['host'], $parsed['port'], $parsed['path'], $sslOptions);
Expand Down