Additional functions for the Char module to check common character properties
#467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It looks like there's some issue in the CI with missing |
Owner
|
It looks good overall, good idea! Can you rebase instead of having a merge commit? I'd also like at least a few tests on this one. I did look at the ascii table, but tests don't hurt :) |
Contributor
Author
|
Thanks. I rebased and will push tomorrow after adding some tests. |
Contributor
Author
|
Sorry about the git mess; I had a rough morning... Should all be good now. |
Owner
|
That's great, thanks!
yeah that happens 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some functions to check whether a given character is uppercase, lowercase, a letter, a digit, or white-space, respectively. These are particularly useful in building predicates for
CCStringfunctions likecontains,exists, &c. Let me know what you think, and if you want any changes.The names align with the convention set by Stdlib's
Charof indicating the character encoding nominally.