-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH-SEA021 #5
base: main
Are you sure you want to change the base?
ENH-SEA021 #5
Conversation
rm -f realtime_rawnc/* | ||
rm -f L1-timeseries/* | ||
rm -f L1-profiles/* | ||
rm -f L2-gridfiles/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to make these all L0 to match the rest of the repo
long_name: oxygen concentration | ||
standard_name: mole_concentration_of_dissolved_molecular_oxygen_in_sea_water | ||
units: umol l-1 | ||
coordinates: time depth latitude longitude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps swap the units for "unknown" if we're not sure what the oxygen is doing here
# Make level-1 timeseries netcdf file from th raw files... | ||
outname = seaexplorer.raw_to_L0timeseries(rawncdir, l0tsdir, deploymentyaml, kind='sub') | ||
ncprocess.extract_L1timeseries_profiles(outname, profiledir, deploymentyaml) | ||
outname2 = ncprocess.make_L2_gridfiles(outname, griddir, deploymentyaml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two lines will need to use extract_L0timeseries_profiles
and make_L2_gridfiles
respectively
pldGPCTD = pldGPCTD.drop_vars(arod) | ||
for vars in [flbbcd, arod]: | ||
try: | ||
pldGPCTD = pldGPCTD.drop_vars(vars) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example runs with the changes to pyglider/seaexplorer.py made in #14 which is promising.
I tested the results by compaing the dataset produced by this version of seaexplorer.py
and the one in #14 using the xarray equals function they are identical. So we can use either this version or that suggested in #14 no problem. This could also be a handy function for testing purposes
fc6deb2
to
9cec8bf
Compare
Some changes to make SEA021 work. Don't have correct info in deployment.yml yet, and I have no idea what units the O2 measurements are in, but at least they are processed bu these changes....