Tests for MakeUserCommand #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @danjohnson95! |
jbrooksuk
added a commit
that referenced
this pull request
May 11, 2025
* main: (38 commits) Fixes Fix date order for past incidents in history (#237) (#255) Add Koren translation to config Add ko translation (#265) Add Edit Profile page (#276) Bump vite from 5.4.18 to 5.4.19 (#277) Add coverage testing (#260) Add trusted proxies to Cachet config Add comment Bump vite from 5.4.14 to 5.4.18 (#273) Bump minor larastan version (#271) Compile Assets Tests for MakeUserCommand (#268) Fix code styling Fix PHPStan errors Complete french translations (#269) Added spanish (Spain) translations (#266) Set `NIGHTWATCH_ENABLED` to `false` in CI Use parallel testing and lint as part of testing (#259) Remove unused metric points update route ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off a recent conversation in Discord - frank42 mentioned that a user is being created as a non-admin even when they said "Yes" to the admin prompt.
I can't replicate that particular bug, but I thought it'd be good to have some tests on this command anyway.
This also fixes a bug where if the arguments are passed directly to the command, and you're creating a non-admin user, the command would still ask if the user should be an admin.