Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Tweaks for multi go version tests #3673

Merged
merged 7 commits into from
Aug 21, 2020
Merged

ci: Tweaks for multi go version tests #3673

merged 7 commits into from
Aug 21, 2020

Conversation

francislavoie
Copy link
Member

@francislavoie francislavoie commented Aug 20, 2020 •
edited
Loading

  • Build cache should be per go version
  • We can shorten the matrix var to just go
  • Publish separate CI artifacts per go version, drop the _v2 infix (kinda meaningless)
  • Specify the go version in a short format without the .x, looks cleaner
  • Bump release to go 1.15, (but not fuzzing, it's not ready for 1.15 yet)
  • Bump setup-go to v2, cache to v2, goreleaser-action to v2

@francislavoie
ci: Tweaks for multi go version tests
42eb3a8 
- Build cache should be per go version
- We can shorten the matrix var
- Publish separate CI artifacts per go version
- Specify the go version in a short format (should work according to setup-go docs, I think)
@francislavoie
ci: Do the same for cross-build
7a68f5e
@francislavoie
Copy link
Member Author

@mholt merge this before releasing, because otherwise the release will be with go 1.14 builds

mohammed90
mohammed90 approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out (besides what's already highlighted and resolved). Thanks, Francis! 🎉

@mohammed90 mohammed90 closed this Aug 20, 2020
@mohammed90 mohammed90 reopened this Aug 20, 2020
@francislavoie francislavoie reopened this Aug 20, 2020
@francislavoie francislavoie reopened this Aug 20, 2020
@francislavoie francislavoie added this to the v2.2.0 milestone Aug 20, 2020
mholt
mholt approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much Francis and Mohammed!

@francislavoie francislavoie merged commit ecbc1f8 into caddyserver:master Aug 21, 2020
@francislavoie francislavoie deleted the ci-tweaks branch August 21, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammed90 mohammed90 mohammed90 approved these changes

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@francislavoie @mholt @mohammed90