-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Otel Trace client interactions #6487
base: master
Are you sure you want to change the base?
Conversation
I kinda want |
Hey, sorry for the lack of response. I'm not really savvy with OTel, so I want to leave this for someone else to review. @francislavoie Do you know who might be the best reviewer for this? |
Odd the lint errors I am getting appear to be from places I didn't touch. |
They appeared with the new Go version. I'm fixing them locally, then you can merge once pushed and merged from my side. |
@mohammed90 do you have a branch pushed I just merge from? |
Patience is good |
Confirmed to be false-positive in gosec bound-check: securego/gosec#1189. Ignore the lint failure for now. |
So we need a commit to adjust the rules first so my PR will be able to merge it. |
Should be okay now for the most part it works well see trajano/google-fonts-proxy-docker#7 (comment) for a screenshot
But there's one
context.TODO()
line I am not sure which context to pass in at that point.